Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return a list from GetCommitsFromIDs #12981

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Always return a list from GetCommitsFromIDs #12981

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13fe079
Always return a list from GetCommitsFromIDs
zeripath Sep 29, 2020
91bc4c8
Merge branch 'master' into fix-12953-prevent-NPE-in-issue_comments
zeripath Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions modules/git/repo_commit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,10 +504,6 @@ func (repo *Repository) getBranches(commit *Commit, limit int) ([]string, error)

// GetCommitsFromIDs get commits from commit IDs
func (repo *Repository) GetCommitsFromIDs(commitIDs []string) (commits *list.List) {
if len(commitIDs) == 0 {
return nil
}

commits = list.New()

for _, commitID := range commitIDs {
Expand Down