Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for pull-request merge #1912

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Add integration test for pull-request merge #1912

merged 1 commit into from
Jun 15, 2017

Conversation

typeless
Copy link
Contributor

@typeless typeless commented Jun 8, 2017

This is not finished yet.

@typeless typeless mentioned this pull request Jun 8, 2017
Closed
7 tasks
@typeless typeless force-pushed the add-integration-test-for-pr-merge branch 2 times, most recently from aef6785 to 113b3e9 Compare June 8, 2017 12:00
@ethantkoenig ethantkoenig mentioned this pull request Jun 10, 2017
Merged
@bkcsoft bkcsoft added the pr/wip This PR is not ready for review label Jun 11, 2017
@lunny
Copy link
Member

lunny commented Jun 15, 2017

So this should be dropped since #1972 merged? @typeless

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 15, 2017
@typeless
Copy link
Contributor Author

@lunny No. I'll continue this based on #1972 . The "merge" button test is going to be added in this PR.

@typeless typeless force-pushed the add-integration-test-for-pr-merge branch from 113b3e9 to f4eac2f Compare June 15, 2017 10:03
@typeless typeless changed the title [WIP] Add integration test for pull-request merge Add integration test for pull-request merge Jun 15, 2017
@typeless
Copy link
Contributor Author

Ready for review. Please remove the WIP label.

@lunny lunny removed the pr/wip This PR is not ready for review label Jun 15, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 15, 2017
@lunny
Copy link
Member

lunny commented Jun 15, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 15, 2017
@sapk
Copy link
Member

sapk commented Jun 15, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2017
@lunny lunny merged commit 01322af into go-gitea:master Jun 15, 2017
@typeless typeless deleted the add-integration-test-for-pr-merge branch September 5, 2017 10:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@typeless @lunny @sapk @tboerger @bkcsoft