Skip to content

Use temporary file to avoid out-of-memory when receiving big chunks. #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use temporary file to avoid out-of-memory when receiving big chunks. #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cb89bc
Use temporary file to avoid out-of-memory when receiving big chunk.
typeless Oct 10, 2016
a0ca633
Must close the open file to avoid fd leaks
typeless Oct 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions routers/repo/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,14 +364,23 @@ func serviceRPC(h serviceHandler, service string) {
}

if h.cfg.OnSucceed != nil {
input, err = ioutil.ReadAll(reqBody)
tmpfile, err := ioutil.TempFile("", "gogs")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't found info about the permissions that TempFile would put on the file, I guess it should be checked

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/golang/go/blob/master/src/io/ioutil/tempfile.go#L55

Is this what you are looking for?

if err != nil {
log.GitLogger.Error(2, "fail to read request body: %v", err)
log.GitLogger.Error(2, "fail to create temporary file: %v", err)
h.w.WriteHeader(http.StatusInternalServerError)
return
}
defer os.Remove(tmpfile.Name())
defer tmpfile.Close()

br = bytes.NewReader(input)
_, err = io.Copy(tmpfile, reqBody)
if err != nil {
log.GitLogger.Error(2, "fail to save request body: %v", err)
h.w.WriteHeader(http.StatusInternalServerError)
return
}

br = tmpfile
} else {
br = reqBody
}
Expand Down