Fix margin and alignment in dashboard repolist #22120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems this has recently regressed, previously, there was a significant whitespace between icon and text, but it seems to be gone, so I added the margin.
silverwind
force-pushed
the
margin-repos
branch
from
bdfdd69 to
a666f3f
Compare
lunny
approved these changes
Dec 14, 2022
GiteaBot
added
the
lgtm/need 1
techknowlogick
added
the
outdated/backport/v1.18
|
Putting in draft, need to fix text truncation in the flexbox. |
|
Truncation fixed. The repo name can now stretch the full box instead of the previous arbitrary 70% value:
|
KN4CK3R
approved these changes
Dec 16, 2022
GiteaBot
added
lgtm/done
KN4CK3R
pushed a commit
that referenced
this pull request
Dec 16, 2022
|
make L-G-T-M work |
|
please send backport |
|
Was already backported to 1.18 in #22122 and 1.17 does not have the bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems this has recently regressed, previously, there was a significant whitespace between icon and text, but it seems to be gone, so I added the margin and also vertically aligned the icon because it was slightly misaligned.
Before:
After:
