fixes 500 error on dashboard when using MSSQL #2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSSQL rejects the query:
SELECT "repository"."id" FROM "repository"
INNER JOIN "team_repo" ON "team_repo".repo_id="repository".id AND
"repository".is_mirror=1
WHERE (
("repository".owner_id=2 AND "repository".is_private=0)
OR team_repo.team_id IN (1)
)
GROUP BY "repository".id ORDER BY updated_unix DESC
when the order by term (updated_unix) is not included in the group by
term.
Codecov Report
@@ Coverage Diff @@
## master #2504 +/- ##
======================================
Coverage 27.7% 27.7%
======================================
Files 83 83
Lines 16914 16914
======================================
Hits 4686 4686
Misses 11553 11553
Partials 675 675
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
LGTM |
tboerger
added
lgtm/need 1
|
any feedback on the quality of my commit message would be appreciated. Thanks |
|
It describes changes so it is understandable what change fixes, I think it is good ;) |
|
LGTM |
tboerger
added
lgtm/done
|
Make LG-TM work :) |
7 tasks
lafriks
pushed a commit
to lafriks-fork/gitea
that referenced
this pull request
Oct 5, 2017
MSSQL rejects the query:
SELECT "repository"."id" FROM "repository"
INNER JOIN "team_repo" ON "team_repo".repo_id="repository".id AND
"repository".is_mirror=1
WHERE (
("repository".owner_id=2 AND "repository".is_private=0)
OR team_repo.team_id IN (1)
)
GROUP BY "repository".id ORDER BY updated_unix DESC
when the order by term (updated_unix) is not included in the group by
term.
lafriks
added a commit
that referenced
this pull request
Oct 5, 2017
MSSQL rejects the query:
SELECT "repository"."id" FROM "repository"
INNER JOIN "team_repo" ON "team_repo".repo_id="repository".id AND
"repository".is_mirror=1
WHERE (
("repository".owner_id=2 AND "repository".is_private=0)
OR team_repo.team_id IN (1)
)
GROUP BY "repository".id ORDER BY updated_unix DESC
when the order by term (updated_unix) is not included in the group by
term.
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo-as-gitea-fork
that referenced
this pull request
Jan 23, 2025
- Backport of go-gitea#2649 - Resolves go-gitea#2504 (cherry picked from commit 773048a)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSSQL rejects the query:
when the order by term (updated_unix) is not included in the group by term.