Skip to content

Conversation

cez81
Copy link
Contributor

@cez81 cez81 commented Oct 17, 2017

Fix #2535

Last updated was set every time the mirror object was updated. Change so that it's only updated after a successful sync.

@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #2730 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
- Coverage   26.91%   26.91%   -0.01%     
==========================================
  Files          87       87              
  Lines       17285    17286       +1     
==========================================
  Hits         4652     4652              
- Misses      11954    11955       +1     
  Partials      679      679
Impacted Files Coverage Δ
models/repo_mirror.go 0.62% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30afce1...af9d57b. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 17, 2017
@pgaskin
Copy link
Contributor

pgaskin commented Oct 18, 2017

Trusted LGTM, but a question: what is considered a successful sync? When a commit is added? When git returns no errors? Something else?

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 18, 2017
@lafriks
Copy link
Member

lafriks commented Oct 18, 2017

LGTM - @geek1011 successful sync is when sync ends without errors (even if there was nothing new)

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 18, 2017
@cez81
Copy link
Contributor Author

cez81 commented Oct 18, 2017

@geek1011 I have another issue concerning mirror last updated times, #1329. Will have look at that next.

@lafriks lafriks added this to the 1.3.0 milestone Oct 18, 2017
@lafriks
Copy link
Member

lafriks commented Oct 18, 2017

Make LG-TM work again

@lafriks lafriks merged commit 847272a into go-gitea:master Oct 18, 2017
@cez81 cez81 deleted the mirror_bug branch October 18, 2017 18:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect last updated time of mirrors after save settings
5 participants