Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SSH clone URL generation code (#28421) #28480

Merged
merged 1 commit into from Dec 15, 2023
Merged

Refactor SSH clone URL generation code (#28421) #28480

merged 1 commit into from Dec 15, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #28421 by @wxiaoguang

Refactor the code and add tests, keep the old logic.

@wxiaoguang @GiteaBot
Refactor SSH clone URL generation code (go-gitea#28421)
319928e 
Refactor the code and add tests, keep the old logic.
@GiteaBot GiteaBot added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 15, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2023
@GiteaBot GiteaBot added this to the 1.21.3 milestone Dec 15, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 15, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 15, 2023 06:35
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 15, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2023
@wxiaoguang wxiaoguang merged commit 6cbb6f3 into go-gitea:release/v1.21 Dec 15, 2023
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GiteaBot @wxiaoguang @Zettat123