Skip to content

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 26, 2017

Fixes #2976

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 26, 2017
@codecov-io
Copy link

codecov-io commented Nov 26, 2017

Codecov Report

Merging #2978 into master will decrease coverage by <.01%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2978      +/-   ##
==========================================
- Coverage   32.53%   32.52%   -0.01%     
==========================================
  Files         267      267              
  Lines       39270    39270              
==========================================
- Hits        12776    12773       -3     
- Misses      24700    24710      +10     
+ Partials     1794     1787       -7
Impacted Files Coverage Δ
modules/context/context.go 48.97% <0%> (ø) ⬆️
modules/context/repo.go 59.92% <0%> (ø) ⬆️
routers/repo/commit.go 16.26% <0%> (ø) ⬆️
routers/repo/search.go 54.16% <100%> (ø) ⬆️
routers/repo/pull.go 34.26% <50%> (ø) ⬆️
models/repo_indexer.go 49% <0%> (-2.98%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-2.61%) ⬇️
models/repo.go 38% <0%> (+0.18%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5c6b6...7cbc5a4. Read the comment docs.

@lafriks lafriks force-pushed the fix/image_preview_url branch from 7b2c892 to 177e4cd Compare November 26, 2017 18:30
@lunny
Copy link
Member

lunny commented Nov 27, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2017
@lafriks lafriks force-pushed the fix/image_preview_url branch from 2b1718a to 7cbc5a4 Compare November 27, 2017 00:51
@lafriks lafriks merged commit 0d4c63f into go-gitea:master Nov 27, 2017
@lafriks lafriks deleted the fix/image_preview_url branch November 27, 2017 00:59
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Nov 27, 2017
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 27, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken images url in commit
5 participants