Skip to content

Add fingerprint to ssh key endpoints. #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2017
Merged

Add fingerprint to ssh key endpoints. #3009

merged 2 commits into from
Nov 28, 2017

Conversation

vtemian
Copy link
Contributor

@vtemian vtemian commented Nov 28, 2017

This PR will fix #3002 by adding fingerprint to ssh key related endpoints.

@vtemian vtemian mentioned this pull request Nov 28, 2017
Merged
@lunny
Copy link
Member

lunny commented Nov 28, 2017

Please govendor update code.gitea.io/sdk/gitea.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2017
@vtemian vtemian force-pushed the 3002-add-fingerprint-to-api branch from 35294a5 to bd3ce05 Compare November 28, 2017 15:08
@lunny lunny added type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them labels Nov 28, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 28, 2017
@lunny
Copy link
Member

lunny commented Nov 28, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2017
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0c69b76). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3009   +/-   ##
=========================================
  Coverage          ?   32.73%           
=========================================
  Files             ?      267           
  Lines             ?    39189           
  Branches          ?        0           
=========================================
  Hits              ?    12828           
  Misses            ?    24539           
  Partials          ?     1822
Impacted Files Coverage Δ
routers/api/v1/convert/convert.go 61.64% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c69b76...bd3ce05. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented Nov 28, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2017
@lafriks lafriks merged commit 6ad4990 into go-gitea:master Nov 28, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Add fingerprint field to keys api endpoints
5 participants
@vtemian @lunny @codecov-io @lafriks @tboerger