Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete monaco workaround #30893

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

silverwind
Copy link
Member

This workaround is not neccessary any more since monaco 0.35.0.

Ref: microsoft/monaco-editor#2962
Ref: microsoft/vscode#173688

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 7, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) May 8, 2024 02:37
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 8, 2024
@techknowlogick techknowlogick merged commit d9b37d0 into go-gitea:main May 8, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 8, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 8, 2024
@silverwind silverwind deleted the rmw branch May 8, 2024 09:18
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 9, 2024
* giteaofficial/main:
  Add missing menu active item background back (go-gitea#30897)
  Fix misspelling of mergable (go-gitea#30896)
  Fix incorrect issue form (go-gitea#30881)
  Update issue indexer after merging a PR (go-gitea#30715)
  Fix various problems around projects board view (go-gitea#30696)
  Fix wrong transfer hint (go-gitea#30889)
  Remove obsolete monaco workaround (go-gitea#30893)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants