Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing menu active item background back #30897

Merged
merged 2 commits into from
May 8, 2024
Merged

Add missing menu active item background back #30897

merged 2 commits into from
May 8, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #30578

image

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.22 This PR should be backported to Gitea 1.22 labels May 8, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 8, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2024
@wxiaoguang wxiaoguang mentioned this pull request May 8, 2024
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2024
@silverwind
Copy link
Member

silverwind commented May 8, 2024 •
edited
Loading

Not sure if this is a complete fix. I will check later. In v1.21, this style was provided by this rule:

.ui.menu .active.item,
.ui.menu .active.item:hover,
.ui.vertical.menu .active.item,
.ui.vertical.menu .active.item:hover {
  color: var(--color-text);
  background: var(--color-active);
}

Somehow this must have gotten lost during #30325 or another PR.

silverwind
silverwind requested changes May 8, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until I verified this.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2024
@wxiaoguang
Copy link
Contributor Author

I have checked there is .ui.menu .active.item { background: var(--color-active);

And I think current UI looks good enough so there is no need to add :hover.

Feel free to double check and edit this PR if necessary

silverwind
silverwind approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Another option may be to remove .ui.vertical.menu .item { background: none }, but I'm not sure whether this has side-effects.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels May 8, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 8, 2024 22:56
@wxiaoguang wxiaoguang merged commit ed0fc27 into go-gitea:main May 8, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 8, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 8, 2024
@wxiaoguang @GiteaBot
Add missing menu active item background back (go-gitea#30897)
edb49a5 
Fix go-gitea#30578
@GiteaBot GiteaBot mentioned this pull request May 8, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 8, 2024
@wxiaoguang wxiaoguang deleted the fix-menu-item branch May 8, 2024 23:03
wxiaoguang added a commit that referenced this pull request May 8, 2024
@GiteaBot @wxiaoguang
Add missing menu active item background back (#30897) (#30907)
08d697a 
Backport #30897 by wxiaoguang

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 9, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3838b37 
* giteaofficial/main:
  Add missing menu active item background back (go-gitea#30897)
  Fix misspelling of mergable (go-gitea#30896)
  Fix incorrect issue form (go-gitea#30881)
  Update issue indexer after merging a PR (go-gitea#30715)
  Fix various problems around projects board view (go-gitea#30696)
  Fix wrong transfer hint (go-gitea#30889)
  Remove obsolete monaco workaround (go-gitea#30893)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Selected workflow will not be highlighted
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot