Recognize more characters in crossreferenced repo name #3413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3413 +/- ##
=========================================
Coverage ? 35.64%
=========================================
Files ? 281
Lines ? 40552
Branches ? 0
=========================================
Hits ? 14456
Misses ? 23962
Partials ? 2134
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
thehowl
reviewed
Jan 26, 2018
| // CrossReferenceIssueNumericPattern matches string that references a numeric issue in a different repository | ||
| // e.g. gogits/gogs#12345 | ||
| CrossReferenceIssueNumericPattern = regexp.MustCompile(`( |^)[0-9a-zA-Z]+/[0-9a-zA-Z]+#[0-9]+\b`) | ||
| CrossReferenceIssueNumericPattern = regexp.MustCompile(`( |^)[0-9a-zA-Z-_\.]+/[0-9a-zA-Z-_\.]+#[0-9]+\b`) |
There was a problem hiding this comment.
Before anyone researches this: did that already - both RegisterForm and CreateRepoForm in modules/auth use AlphaDashDot as a rule in the binding field, which in turn inside macaron is converted into "Every string that matches this should be rejected".
tboerger
added
lgtm/need 1
|
LGTM. (Off topic: why the CI Successfully this PR?) |
tboerger
added
lgtm/done
|
@lunny it does succeed time to time :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3412