Skip to content

Use standalone function to update repository cols #34811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2025
Merged

Use standalone function to update repository cols #34811

merged 6 commits into from
Jun 26, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 21, 2025 •
edited
Loading

Extract UpdateRepository
Follow up #34762

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 21, 2025
@wxiaoguang
Copy link
Contributor

admin sync_repo_branches will update all repo last_update_time even repo no change #34831

@lunny
Copy link
Member Author

lunny commented Jun 24, 2025

admin sync_repo_branches will update all repo last_update_time even repo no change #34831

27f484e

@lunny lunny added the backport/v1.24 This PR should be backported to Gitea 1.24 label Jun 24, 2025
@lunny lunny requested a review from wxiaoguang June 25, 2025 03:08
wxiaoguang
wxiaoguang reviewed Jun 25, 2025
View reviewed changes
@wxiaoguang
Copy link
Contributor

And why so many inconsistencies.

  • Why UpdateRepositoryColsXxxAutoTime ignores empty "cols", but other UpdateXxx treats empty Cols as default.
  • Why UpdateRepositoryHealthCheck and UpdateRepositoryTrustModel have their own functions but ObjectFormat doesn't

Why .......

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2025
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed backport/v1.24 This PR should be backported to Gitea 1.24 labels Jun 26, 2025
@lunny lunny enabled auto-merge (squash) June 26, 2025 16:56
@lunny lunny merged commit 0771a79 into go-gitea:main Jun 26, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jun 26, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 26, 2025
@wxiaoguang wxiaoguang deleted the lunny/refactor_updaterepository branch June 26, 2025 23:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 27, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7881a93 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Use standalone function to update repository cols (go-gitea#34811)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @hiifong @GiteaBot