Skip to content

Add issue closed time column to fix activity closed issues list #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2018
Merged

Add issue closed time column to fix activity closed issues list #3537

merged 1 commit into from
Feb 19, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Feb 18, 2018

Fixes #3481

@lafriks
Add issue closed time column to fix activity closed issues list
1d9961d 
Signed-off-by: Lauris Bukšis-Haberkorns <lauris@nix.lv>
@lafriks lafriks added this to the 1.5.0 milestone Feb 18, 2018
@codecov-io
Copy link

Codecov Report

Merging #3537 into master will decrease coverage by 0.01%.
The diff coverage is 32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3537      +/-   ##
==========================================
- Coverage   35.75%   35.74%   -0.02%     
==========================================
  Files         283      284       +1     
  Lines       40752    40773      +21     
==========================================
+ Hits        14572    14575       +3     
- Misses      24022    24039      +17     
- Partials     2158     2159       +1
Impacted Files Coverage Δ
models/migrations/migrations.go 2.89% <ø> (ø) ⬆️
models/migrations/v57.go 0% <0%> (ø)
models/repo_activity.go 66.27% <100%> (+0.8%) ⬆️
models/issue.go 46.69% <33.33%> (-0.09%) ⬇️
models/repo_list.go 65.62% <0%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2c176...1d9961d. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 18, 2018
@lafriks lafriks mentioned this pull request Feb 18, 2018
Merged
@lunny
Copy link
Member

lunny commented Feb 19, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2018
@appleboy appleboy merged commit 5889338 into go-gitea:master Feb 19, 2018
@lafriks lafriks deleted the fix/activity_close_date branch February 19, 2018 05:10
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Feb 19, 2018
@lafriks
Add issue closed time column to fix activity closed issues list (go-g…
a942fb6 
…itea#3537)

Signed-off-by: Lauris Bukšis-Haberkorns <lauris@nix.lv>
@lafriks lafriks mentioned this pull request Feb 19, 2018
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 19, 2018
lafriks added a commit that referenced this pull request Feb 19, 2018
@lafriks
Add issue closed time column to fix activity closed issues list (#3537)…
e8015a5 
… (#3540)

Signed-off-by: Lauris Bukšis-Haberkorns <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Repo Activity: Date filter uses issue creation date for closed issues
5 participants
@lafriks @codecov-io @lunny @appleboy @tboerger