Skip to content

Conversation

ChristopherHX
Copy link
Contributor

Closes #35361

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 29, 2025
@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 29, 2025
@lunny lunny added this to the 1.25.0 milestone Aug 29, 2025
@wxiaoguang

This comment was marked as resolved.

* move logic into a shared function
@silverwind
Copy link
Member

Still WIP?

@ChristopherHX
Copy link
Contributor Author

... I am validating my own change now, this is the reason for being a draft. I hope someone else can validate the gpg key case, do not currently have the required setup.

image

We could also mention this is an ssh key.

Now the mentioned case of wxiaoguang is still missing from my side.

@ChristopherHX
Copy link
Contributor Author

The other case is this one: Editing a file, but this is hidden in the title.

image

@ChristopherHX ChristopherHX marked this pull request as ready for review September 10, 2025 09:56
@ChristopherHX
Copy link
Contributor Author

GPG Screens

image image

@wxiaoguang wxiaoguang force-pushed the fix-SSH-signing-key-path-will-be-displayed-in-the-pull-request-UI branch from ace208c to 51081d9 Compare September 11, 2025 00:48
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Sep 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 12, 2025
@lunny lunny enabled auto-merge (squash) September 12, 2025 03:00
@lunny lunny merged commit 84812e4 into go-gitea:main Sep 12, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 12, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 13, 2025
* giteaofficial/main:
  Fix different behavior in status check pattern matching with double stars (go-gitea#35474)
  Replace webpack with rspack (go-gitea#35460)
  Don't store repo archives on `gitea dump` (go-gitea#35467)
  Fix SSH signing key path will be displayed in the pull request UI (go-gitea#35381)
  [skip ci] Updated translations via Crowdin
  Update image name in integration README (go-gitea#35465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH signing key path will be displayed in the pull request UI
5 participants