Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 31, 2025

Extend the maximum length of comment.treepath from 255 to 4000 characters.

All databases supported by Gitea allow VARCHAR fields of 4000, so compatibility is ensured. Git itself does not impose a strict limit on path length. On Windows, the core.longpaths setting has already been enabled to handle long file paths.

Fix #33716

@lunny lunny added the type/bug label Aug 31, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/migrations labels Aug 31, 2025
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
@lunny lunny added this to the 1.25.0 milestone Sep 1, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 10, 2025
@silverwind silverwind enabled auto-merge (squash) September 10, 2025 13:15
@silverwind silverwind merged commit 2653ac9 into go-gitea:main Sep 10, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 10, 2025
@lunny lunny deleted the lunny/extend_comment_treepath_length branch September 10, 2025 14:38
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 11, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix package link setting can only list limited repositories (go-gitea#35394)
  Vertically center date in file view latest commit (go-gitea#35456)
  Bump setup-node to v5 (go-gitea#35448)
  Extend comment treepath length (go-gitea#35389)
  Fix overflow in notifications list (go-gitea#35446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/migrations type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating comment on a file with filename+path longer than 256 chars leads to 500 internal server error
5 participants