Skip to content

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Sep 8, 2025

gofumpt now supports the ignore directive added in go 1.25, make use of it which speeds up make fmt by around 30%. Likely this also has similar speed gains in other go-related commands which use the ./... pattern.

The change in build/code-batch-process.go was introduced by gofumpt because of this change:

A new rule is introduced to "clothe" naked returns for the sake of clarity. While there is nothing wrong with naming results in function signatures, using lone return statements can be confusing to the reader.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 8, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 8, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 8, 2025
@6543 6543 merged commit bde1f82 into go-gitea:main Sep 8, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Sep 8, 2025
@silverwind silverwind deleted the goignore branch September 8, 2025 12:47
@lunny lunny modified the milestones: 1.26.0, 1.25.0 Sep 8, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 10, 2025
* giteaofficial/main:
  Fix a compare page 404 bug when the pull request disabled (go-gitea#35441)
  Use db.WithTx/WithTx2 instead of TxContext when possible (go-gitea#35428)
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#35444)
  check user and repo for redirects when using git via SSH transport (go-gitea#35416)
  Fix push commits comments when changing the pull request target branch (go-gitea#35386)
  Fix bug when issue disabled, pull request number in the commit message cannot be redirected (go-gitea#35420)
  [skip ci] Updated translations via Crowdin
  Update gofumpt, add go.mod ignore directive (go-gitea#35434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code modifies/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants