Skip to content

Add sensitive url string to avoid leak in log messages #35594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add sensitive url string to avoid leak in log messages #35594

wants to merge 3 commits into from
+84 −49

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 6, 2025

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 6, 2025
@lunny lunny mentioned this pull request Oct 6, 2025
Open
@shashank-netapp
Copy link

shashank-netapp commented Oct 7, 2025 •
edited
Loading

As we've already created a SensitiveString type, wouldn't it be better to do the sanitization work in .String function itself ? This way we'll avoid doing any type of calculation in the log level function call. And also any of the fmt's would already be sanitized to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunny @shashank-netapp @GiteaBot