-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
The status icon of the Action step is consistent with GitHub #35618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
The SVG source should be in |
@wxiaoguang Sorry, I'm not very familiar with Git and don't know how to backport it to 1.25 😖 |
Assuming no merge conflicts, backport is performed automatically after merge and you don't need to do anything. |
As a future improvement, we could animate |
I tried to implement it with AI and it looks good, but AI seems to indicate that this technology has been abandoned? CSS animations should be used for implementation, and Github also uses CSS for implementation. <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16" height="16">
<path fill="none" stroke="currentColor" stroke-width="2" d="M3.05 3.05a7 7 0 1 1 9.9 9.9 7 7 0 0 1-9.9-9.9Z" opacity=".5"></path>
<path fill="currentColor" fill-rule="evenodd" d="M8 4a4 4 0 1 0 0 8 4 4 0 0 0 0-8Z" clip-rule="evenodd"></path>
<path fill="currentColor" d="M14 8a6 6 0 0 0-6-6V0a8 8 0 0 1 8 8h-2Z">
<animateTransform attributeName="transform" type="rotate" from="0 8 8" to="360 8 8" dur="1s" repeatCount="indefinite" />
</path>
</svg> |
No, SMIL is not abandoned. A few years ago Google wanted to kill it but they have since reverted their stance and it'll stay as part of the web platform. I like it because it enables self-contained SVG animations. |
Do we need to add this part to this merger? I saw on GitHub that the merge has been locked. If using SVG SMIL, the class name of the animation should also be removed, and overlaying CSS animation will accelerate rotation. |
No need to make it that complex. |
Let's keep it to CSS. It at least is more broadly supported than SMIL (I'm thinking of browsers like Palemoon or Ladybird). |
Got it, Gitea's level of similarity to GitHub has increased by another 1% 😄 |
…a#35618) Before: running: <img width="45" height="34" alt="image" src="https://github.com/user-attachments/assets/e2508f98-2f1f-4b7e-a80c-30b406f42531" /> waiting: <img width="44" height="33" alt="image" src="https://github.com/user-attachments/assets/e7c8164e-fdc3-4546-b088-31166544edb0" /> --- After: running: <img width="49" height="43" alt="image" src="https://github.com/user-attachments/assets/b5a9b245-a995-458a-af23-d1723daa3692" /> waiting: <img width="42" height="44" alt="image" src="https://github.com/user-attachments/assets/ff72551e-cfb5-4665-af52-938ef0cf8f1c" /> `gitea-running.svg` is not an icon from the @ primer/octicon library, extracted from the Github page. Github did not assign a clear class name to this icon --------- Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com> Co-authored-by: lutinglt <lutinglt@users.noreply.github.com>
…#35621) Backport #35618 by @lutinglt #35616 Before: running: <img width="45" height="34" alt="image" src="https://github.com/user-attachments/assets/e2508f98-2f1f-4b7e-a80c-30b406f42531" /> waiting: <img width="44" height="33" alt="image" src="https://github.com/user-attachments/assets/e7c8164e-fdc3-4546-b088-31166544edb0" /> --- After: running: <img width="49" height="43" alt="image" src="https://github.com/user-attachments/assets/b5a9b245-a995-458a-af23-d1723daa3692" /> waiting: <img width="42" height="44" alt="image" src="https://github.com/user-attachments/assets/ff72551e-cfb5-4665-af52-938ef0cf8f1c" /> `gitea-running.svg` is not an icon from the @ primer/octicon library, extracted from the Github page. Github did not assign a clear class name to this icon Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com> Co-authored-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com> Co-authored-by: lutinglt <lutinglt@users.noreply.github.com>
* giteaofficial/main: [skip ci] Updated translations via Crowdin Update JS deps, misc tweaks (go-gitea#35643) Bump actions/checkout to v5 (go-gitea#35644) nix flake update (go-gitea#35639) Cleanup ActionRun creation (go-gitea#35624) bump archives&rar dep (go-gitea#35637) Fix merge panic (go-gitea#35606) Bump happy-dom from 19.0.2 to 20.0.0 (go-gitea#35625) Refactor ActionRunJob parsing into a reusable function (go-gitea#35623) Fix code tag style problem and LFS view bug (go-gitea#35628) Support Actions `concurrency` syntax (go-gitea#32751) The status icon of the Action step is consistent with GitHub (go-gitea#35618) Mock external service in hcaptcha TestCaptcha (go-gitea#35604) Fix inputing review comment will remove reviewer (go-gitea#35591) [skip ci] Updated translations via Crowdin Fix diffpatch API endpoint (go-gitea#35610) Print PR-Title into tooltip for actions (go-gitea#35579)
#35616


Before:
running:
waiting:
After:


running:
waiting:
gitea-running.svg
is not an icon from the @ primer/octicon library, extracted from the Github page. Github did not assign a clear class name to this icon