Skip to content

Conversation

lutinglt
Copy link
Contributor

#35616
Before:
running:
image
waiting:
image


After:
running:
image
waiting:
image

gitea-running.svg is not an icon from the @ primer/octicon library, extracted from the Github page. Github did not assign a clear class name to this icon

Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 10, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Oct 10, 2025
@wxiaoguang
Copy link
Contributor

The SVG source should be in web_src/svg and run make svg

@lutinglt
Copy link
Contributor Author

@wxiaoguang Sorry, I'm not very familiar with Git and don't know how to backport it to 1.25 😖

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 10, 2025
@lutinglt lutinglt marked this pull request as ready for review October 10, 2025 10:18
@silverwind
Copy link
Member

@wxiaoguang Sorry, I'm not very familiar with Git and don't know how to backport it to 1.25 😖

Assuming no merge conflicts, backport is performed automatically after merge and you don't need to do anything.

@silverwind
Copy link
Member

As a future improvement, we could animate gitea-running.svg using SVG SMIL.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 10, 2025
@lutinglt
Copy link
Contributor Author

As a future improvement, we could animate gitea-running.svg using SVG SMIL.

I tried to implement it with AI and it looks good, but AI seems to indicate that this technology has been abandoned? CSS animations should be used for implementation, and Github also uses CSS for implementation.

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16" height="16">
  <path fill="none" stroke="currentColor" stroke-width="2" d="M3.05 3.05a7 7 0 1 1 9.9 9.9 7 7 0 0 1-9.9-9.9Z" opacity=".5"></path>
  <path fill="currentColor" fill-rule="evenodd" d="M8 4a4 4 0 1 0 0 8 4 4 0 0 0 0-8Z" clip-rule="evenodd"></path>
  <path fill="currentColor" d="M14 8a6 6 0 0 0-6-6V0a8 8 0 0 1 8 8h-2Z">
    <animateTransform attributeName="transform" type="rotate" from="0 8 8" to="360 8 8" dur="1s" repeatCount="indefinite" />
  </path>
</svg>

gitea-running

@silverwind
Copy link
Member

silverwind commented Oct 10, 2025

No, SMIL is not abandoned. A few years ago Google wanted to kill it but they have since reverted their stance and it'll stay as part of the web platform. I like it because it enables self-contained SVG animations.

@lutinglt
Copy link
Contributor Author

No, SMIL is not abandoned. A few years ago Google wanted to kill it but they have since reverted their stance and it'll stay as part of the web platform. I like it because it enables self-contained SVG animations.

Do we need to add this part to this merger? I saw on GitHub that the merge has been locked.

If using SVG SMIL, the class name of the animation should also be removed, and overlaying CSS animation will accelerate rotation.

@wxiaoguang
Copy link
Contributor

No need to make it that complex.

@silverwind
Copy link
Member

Let's keep it to CSS. It at least is more broadly supported than SMIL (I'm thinking of browsers like Palemoon or Ladybird).

@lutinglt
Copy link
Contributor Author

Got it, Gitea's level of similarity to GitHub has increased by another 1% 😄

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 10, 2025
@lunny lunny merged commit 327d0a7 into go-gitea:main Oct 10, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 10, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 10, 2025
…a#35618)

Before:
running:
<img width="45" height="34" alt="image"
src="https://github.com/user-attachments/assets/e2508f98-2f1f-4b7e-a80c-30b406f42531"
/>
waiting:
<img width="44" height="33" alt="image"
src="https://github.com/user-attachments/assets/e7c8164e-fdc3-4546-b088-31166544edb0"
/>

---
After:
running:
<img width="49" height="43" alt="image"
src="https://github.com/user-attachments/assets/b5a9b245-a995-458a-af23-d1723daa3692"
/>
waiting:
<img width="42" height="44" alt="image"
src="https://github.com/user-attachments/assets/ff72551e-cfb5-4665-af52-938ef0cf8f1c"
/>

`gitea-running.svg` is not an icon from the @ primer/octicon library,
extracted from the Github page. Github did not assign a clear class name
to this icon

---------

Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Co-authored-by: lutinglt <lutinglt@users.noreply.github.com>
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 10, 2025
lunny pushed a commit that referenced this pull request Oct 10, 2025
…#35621)

Backport #35618 by @lutinglt

#35616
Before:
running:
<img width="45" height="34" alt="image"
src="https://github.com/user-attachments/assets/e2508f98-2f1f-4b7e-a80c-30b406f42531"
/>
waiting:
<img width="44" height="33" alt="image"
src="https://github.com/user-attachments/assets/e7c8164e-fdc3-4546-b088-31166544edb0"
/>

---
After:
running:
<img width="49" height="43" alt="image"
src="https://github.com/user-attachments/assets/b5a9b245-a995-458a-af23-d1723daa3692"
/>
waiting:
<img width="42" height="44" alt="image"
src="https://github.com/user-attachments/assets/ff72551e-cfb5-4665-af52-938ef0cf8f1c"
/>

`gitea-running.svg` is not an icon from the @ primer/octicon library,
extracted from the Github page. Github did not assign a clear class name
to this icon

Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Co-authored-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Co-authored-by: lutinglt <lutinglt@users.noreply.github.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 13, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Update JS deps, misc tweaks (go-gitea#35643)
  Bump actions/checkout to v5 (go-gitea#35644)
  nix flake update (go-gitea#35639)
  Cleanup ActionRun creation (go-gitea#35624)
  bump archives&rar dep (go-gitea#35637)
  Fix merge panic (go-gitea#35606)
  Bump happy-dom from 19.0.2 to 20.0.0 (go-gitea#35625)
  Refactor ActionRunJob parsing into a reusable function (go-gitea#35623)
  Fix code tag style problem and LFS view bug (go-gitea#35628)
  Support Actions `concurrency` syntax (go-gitea#32751)
  The status icon of the Action step is consistent with GitHub (go-gitea#35618)
  Mock external service in hcaptcha TestCaptcha (go-gitea#35604)
  Fix inputing review comment will remove reviewer (go-gitea#35591)
  [skip ci] Updated translations via Crowdin
  Fix diffpatch API endpoint (go-gitea#35610)
  Print PR-Title into tooltip for actions (go-gitea#35579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants