Skip to content

Creating push comments before invoke pull request checking #35647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 14, 2025
Merged

Creating push comments before invoke pull request checking #35647

merged 10 commits into from
Oct 14, 2025
+32 −14

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 13, 2025 •
edited
Loading

This PR moved the creation of pushing comments before pull request mergeable checking. So that when the pull request status changed, the comments should have been created.

Replace #35640

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 13, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 13, 2025
@lunny lunny marked this pull request as ready for review October 14, 2025 02:56
@lunny
Copy link
Member Author

lunny commented Oct 14, 2025

This is ready to review now. I have rerun the mssql tests 6 times manually, all succeed and no failure.

@lunny lunny mentioned this pull request Oct 14, 2025
Merged
@lunny lunny changed the title Remove unnecessary AddTestPullRequestTask invoking and adjust adding push comments before checking Creating push comments before invoke pull request checking Oct 14, 2025
wxiaoguang
wxiaoguang reviewed Oct 14, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 14, 2025
@wxiaoguang wxiaoguang mentioned this pull request Oct 14, 2025
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 14, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) October 14, 2025 18:34
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 14, 2025
@techknowlogick techknowlogick merged commit 731d803 into go-gitea:main Oct 14, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 14, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 14, 2025
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.25. @lunny, please send one manually. 🍵

go run ./contrib/backport 35647
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/manual No power to the bots! Create your backport yourself! backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/testing

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @GiteaBot @techknowlogick @wxiaoguang @Zettat123