New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URL validation for external wiki and external issues (#4710) #4740

Merged
merged 1 commit into from Aug 18, 2018

Conversation

5 participants
@lafriks
Copy link
Member

lafriks commented Aug 17, 2018

Backport #4710

Improve URL validation for external wiki and external issues (#4710)
* Improve URL validation for external wiki  and external issues

* Do not allow also localhost address for external URLs

@lafriks lafriks added this to the 1.5.1 milestone Aug 17, 2018

@bkcsoft bkcsoft added the lgtm/need 2 label Aug 17, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Aug 17, 2018

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Aug 17, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Aug 17, 2018

@techknowlogick techknowlogick merged commit 0665154 into go-gitea:release/v1.5 Aug 18, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

glitch003 added a commit to deconet/gitea that referenced this pull request Aug 21, 2018

Improve URL validation for external wiki and external issues (go-gite…
…a#4710) (go-gitea#4740)

* Improve URL validation for external wiki  and external issues

* Do not allow also localhost address for external URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment