New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin should be able to delete repos via the API even if he is not a member of the organization #5443

Merged
merged 1 commit into from Dec 2, 2018

Conversation

6 participants
@adelowo
Member

adelowo commented Dec 1, 2018

Fixes #5442

@lunny lunny modified the milestones: 1.6.1, 1.7.0 Dec 1, 2018

@lunny lunny added the backport/v1.6 label Dec 1, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 1, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@bc42b3a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5443   +/-   ##
=========================================
  Coverage          ?   37.57%           
=========================================
  Files             ?      317           
  Lines             ?    46821           
  Branches          ?        0           
=========================================
  Hits              ?    17593           
  Misses            ?    26734           
  Partials          ?     2494
Impacted Files Coverage Δ
routers/api/v1/repo/repo.go 51.03% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc42b3a...2115af1. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Dec 1, 2018

@adelowo adelowo changed the title from admin should be able to delete repos even if he is not a member of the organization to admin should be able to delete repos via the API even if he is not a member of the organization Dec 1, 2018

@lunny

This comment has been minimized.

Member

lunny commented Dec 2, 2018

Is it necessary since you could delete a repo as admin via /api/v1/admin/repos/delete?

@lafriks

lafriks approved these changes Dec 2, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Dec 2, 2018

@adelowo

This comment has been minimized.

Member

adelowo commented Dec 2, 2018

Is it necessary since you could delete a repo as admin via /api/v1/admin/repos/delete?

I think so since the admin powers should be applicable everywhere

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 2, 2018

@techknowlogick techknowlogick merged commit 9441bfa into go-gitea:master Dec 2, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@techknowlogick

This comment has been minimized.

Member

techknowlogick commented Dec 2, 2018

@adelowo please send backport to release/v1.6 branch 😄

@adelowo adelowo deleted the adelowo:admin_deletion branch Dec 2, 2018

adelowo added a commit to adelowo/gitea that referenced this pull request Dec 2, 2018

@lafriks lafriks changed the title from admin should be able to delete repos via the API even if he is not a member of the organization to Admin should be able to delete repos via the API even if he is not a member of the organization Dec 2, 2018

lafriks added a commit that referenced this pull request Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment