New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix topic name length on database #5493

Merged
merged 2 commits into from Dec 8, 2018

Conversation

@lunny
Copy link
Member

lunny commented Dec 8, 2018

Since we have controlled topic name length is less than 25, so we should change the name column's length.This will fix #5491

@bkcsoft bkcsoft added the lgtm/need 1 label Dec 8, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 8, 2018

Codecov Report

Merging #5493 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5493      +/-   ##
==========================================
- Coverage   37.56%   37.56%   -0.01%     
==========================================
  Files         317      317              
  Lines       46824    46824              
==========================================
- Hits        17591    17589       -2     
- Misses      26734    26737       +3     
+ Partials     2499     2498       -1
Impacted Files Coverage Δ
models/topic.go 54.7% <ø> (ø) ⬆️
models/migrations/v68.go 0% <0%> (ø) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b864a3...444cd06. Read the comment docs.

@Bwko

Bwko approved these changes Dec 8, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 8, 2018

@lafriks

lafriks approved these changes Dec 8, 2018

@lafriks lafriks merged commit 4b4453c into go-gitea:master Dec 8, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Dec 8, 2018

Please send backport

@lunny lunny deleted the lunny:lunny/fix_topic_unique_too_long branch Dec 8, 2018

lunny added a commit that referenced this pull request Dec 8, 2018

@lunny lunny added the backport/done label Dec 8, 2018

lafriks added a commit that referenced this pull request Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment