New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a double slash in the HTTPS redirection when Let's Encrypt is enabled #5537

Merged
merged 1 commit into from Dec 12, 2018

Conversation

5 participants
@gregkare
Copy link
Contributor

gregkare commented Dec 12, 2018

Before:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000//">Found</a>.

After:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000/">Found</a>.

Fixes #5536

@bkcsoft bkcsoft added the lgtm/need 1 label Dec 12, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 12, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@0bd802e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5537   +/-   ##
=========================================
  Coverage          ?   37.57%           
=========================================
  Files             ?      319           
  Lines             ?    46949           
  Branches          ?        0           
=========================================
  Hits              ?    17643           
  Misses            ?    26795           
  Partials          ?     2511

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd802e...6bd01f9. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 12, 2018

@lafriks lafriks merged commit ebef3ef into go-gitea:master Dec 12, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks added the kind/bug label Dec 12, 2018

@lafriks lafriks added this to the 1.7.0 milestone Dec 12, 2018

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Dec 12, 2018

Can you please backport to 1.6 branch?

gregkare added a commit to 67P/gitea that referenced this pull request Dec 13, 2018

@gregkare

This comment has been minimized.

Copy link
Contributor

gregkare commented Dec 13, 2018

@lafriks Done in #5539

@gregkare gregkare deleted the 67P:bugfix/5536-remove_double_slash_letsencrypt branch Dec 13, 2018

techknowlogick added a commit that referenced this pull request Dec 13, 2018

Backport #5537 Remove a double slash in the HTTPS redirect with Let's…
… Encrypt (#5539)

Before:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000//">Found</a>.

After:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000/">Found</a>.

Fixes #5536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment