Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook support custom proxy #8760

Merged
merged 6 commits into from Nov 8, 2019

Conversation

@lunny
Copy link
Member

lunny commented Oct 31, 2019

Currently, webhook will use environment proxy settings, this PR give another possible. You can define a webhook special proxy and indicate which domains you want to use in this domains.

@lunny lunny added this to the 1.11.0 milestone Oct 31, 2019
custom/conf/app.ini.sample Outdated Show resolved Hide resolved
@lunny lunny force-pushed the lunny:lunny/special_proxy_webhook branch from 6a98dde to 01c5859 Nov 3, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 3, 2019

Codecov Report

Merging #8760 into master will increase coverage by 0.01%.
The diff coverage is 62.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8760      +/-   ##
==========================================
+ Coverage   41.22%   41.24%   +0.01%     
==========================================
  Files         544      544              
  Lines       69993    70019      +26     
==========================================
+ Hits        28858    28880      +22     
- Misses      37446    37449       +3     
- Partials     3689     3690       +1
Impacted Files Coverage Δ
modules/setting/webhook.go 56.25% <22.22%> (-43.75%) ⬇️
modules/webhook/deliver.go 47.56% <83.33%> (+4.02%) ⬆️
modules/sync/unique_queue.go 78.57% <0%> (-10.72%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
routers/repo/view.go 37.71% <0%> (-0.88%) ⬇️
models/repo_indexer.go 70.18% <0%> (+3.63%) ⬆️
modules/process/manager.go 82.43% <0%> (+4.05%) ⬆️
modules/indexer/indexer.go 55.26% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016a5d0...7570777. Read the comment docs.

@lunny lunny changed the title WIP: Webhook support custom proxy Webhook support custom proxy Nov 3, 2019
@lunny

This comment has been minimized.

Copy link
Member Author

lunny commented Nov 3, 2019

custom/conf/app.ini.sample Outdated Show resolved Hide resolved
modules/webhook/deliver.go Outdated Show resolved Hide resolved
@lunny lunny force-pushed the lunny:lunny/special_proxy_webhook branch from 9e62614 to 8949b9d Nov 3, 2019
@lunny

This comment has been minimized.

Copy link
Member Author

lunny commented Nov 3, 2019

@guillep2k done.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Nov 3, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Nov 5, 2019
; Proxy server URL, support http://, https//, socks://, blank will follow environment http_proxy/https_proxy
PROXY_URL =
; Comma separated list of host names requiring proxy. Glob patterns (*) are accepted; use ** to match all hosts.
PROXY_HOSTS =

This comment has been minimized.

Copy link
@techknowlogick
Copy link
Member

techknowlogick left a comment

see comment

lunny added 5 commits Oct 31, 2019
@lunny lunny force-pushed the lunny:lunny/special_proxy_webhook branch from dce49e5 to 6f5eb1f Nov 8, 2019
@lunny

This comment has been minimized.

Copy link
Member Author

lunny commented Nov 8, 2019

@techknowlogick techknowlogick merged commit 55bdc9a into go-gitea:master Nov 8, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.