Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error logged when repos qs is empty #9591

Merged
merged 6 commits into from Jan 3, 2020

Conversation

@guillep2k
Copy link
Member

guillep2k commented Jan 2, 2020

Fixes invalid error log in the issues list for the user when no specific repositories are requested.

@techknowlogick techknowlogick added this to the 1.11.0 milestone Jan 2, 2020
@GiteaBot GiteaBot added the lgtm/need 1 label Jan 2, 2020
@lafriks
lafriks approved these changes Jan 2, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 2, 2020
@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Jan 2, 2020

please run make fmt

routers/user/home.go Outdated Show resolved Hide resolved
Co-Authored-By: Lauris BH <lauris@nix.lv>
@guillep2k

This comment has been minimized.

Copy link
Member Author

guillep2k commented Jan 2, 2020

please run make fmt

Sorry, it's been a while. Fixed by applying @lafriks suggestion.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 2, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@4a768e1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9591   +/-   ##
=========================================
  Coverage          ?   42.16%           
=========================================
  Files             ?      578           
  Lines             ?    76015           
  Branches          ?        0           
=========================================
  Hits              ?    32051           
  Misses            ?    39986           
  Partials          ?     3978
Impacted Files Coverage Δ
routers/user/home.go 57.49% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a768e1...3aef6b6. Read the comment docs.

@guillep2k

This comment has been minimized.

Copy link
Member Author

guillep2k commented Jan 2, 2020

@lafriks done.

@6543
6543 approved these changes Jan 2, 2020
@lafriks
lafriks approved these changes Jan 3, 2020
@lafriks lafriks merged commit bedd7b2 into go-gitea:master Jan 3, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.