Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change review content column to type text in db #9229

Merged

Conversation

@davidsvantesson
Copy link
Contributor

davidsvantesson commented Dec 2, 2019

Fix #9207.

@techknowlogick techknowlogick added this to the 1.11.0 milestone Dec 2, 2019
@GiteaBot GiteaBot added the lgtm/need 1 label Dec 2, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Dec 2, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 2, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@33fc48c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9229   +/-   ##
=========================================
  Coverage          ?   41.09%           
=========================================
  Files             ?      555           
  Lines             ?    72393           
  Branches          ?        0           
=========================================
  Hits              ?    29751           
  Misses            ?    38898           
  Partials          ?     3744
Impacted Files Coverage Δ
models/migrations/migrations.go 1.3% <ø> (ø)
models/review.go 53.23% <ø> (ø)
models/migrations/v110.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33fc48c...b49aa65. Read the comment docs.

@techknowlogick techknowlogick merged commit 1aa7e27 into go-gitea:master Dec 2, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Dec 2, 2019

@davidsvantesson thanks for all of the PRs you have made recently :) I believe you are eligible to apply to be a maintainer if you'd be interested in that.

@davidsvantesson davidsvantesson deleted the davidsvantesson:fix-review-content-size branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.