Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mssql migration tests (needs #6823) #6852

Merged
merged 4 commits into from May 5, 2019

Conversation

6 participants
@zeripath
Copy link
Contributor

commented May 5, 2019

This PR adds Migration tests for MSSQL.

It will fail at present due to the bug in v78.go and therefore requires #6823

It will also fail at present because of a bug in v85.go and requires #6851

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

This could be backported to 1.8 easily once #6823 is merged and backported as #6727 has already been backported.

@lunny lunny added the kind/testing label May 5, 2019

@lunny lunny added this to the 1.9.0 milestone May 5, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

Also requires #6823

@zeripath zeripath changed the title Add mssql migration tests Add mssql migration tests (needs #6823) May 5, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@722a2bd). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6852   +/-   ##
=========================================
  Coverage          ?   41.14%           
=========================================
  Files             ?      425           
  Lines             ?    58484           
  Branches          ?        0           
=========================================
  Hits              ?    24061           
  Misses            ?    31238           
  Partials          ?     3185
Impacted Files Coverage Δ
models/migrations/migrations.go 1.52% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722a2bd...2337f3b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 5, 2019

@lafriks

lafriks approved these changes May 5, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 5, 2019

@lafriks lafriks merged commit 0081cd8 into go-gitea:master May 5, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:mssql-migration-tests branch May 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.