Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect noreply email address as user #7133

Merged

Conversation

@zeripath
Copy link
Contributor

commented Jun 5, 2019

Fixes #2457

@GiteaBot GiteaBot added the lgtm/need 1 label Jun 5, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@dadc03f). Click here to learn what that means.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7133   +/-   ##
=========================================
  Coverage          ?   41.59%           
=========================================
  Files             ?      446           
  Lines             ?    60873           
  Branches          ?        0           
=========================================
  Hits              ?    25318           
  Misses            ?    32270           
  Partials          ?     3285
Impacted Files Coverage Δ
models/user.go 51.06% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dadc03f...8bfa72c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jun 5, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

How this resolve that problem?

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

Because the commits that are "misauthored" are commits created using the editor functionality when you have keep email private set. In which case those commits will be authored with the above email address.

@zeripath zeripath added this to the 1.9.0 milestone Jun 6, 2019

@zeripath zeripath added the kind/bug label Jun 6, 2019

@zeripath zeripath merged commit bd55f6f into go-gitea:master Jun 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:detect-no-reply-email-address-as-user branch Jun 6, 2019

@lunny lunny added the backport/v1.8 label Jun 6, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@zeripath please send back port to v1.8

zeripath added a commit to zeripath/gitea that referenced this pull request Jun 13, 2019

techknowlogick added a commit that referenced this pull request Jun 13, 2019

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.