Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 10, 2017

resolved #883

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 10, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 10, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 10, 2017
@strk
Copy link
Member

strk commented Feb 10, 2017

Was the vendor/ change an accident ? It shouldn't be changed w/out updating the commit reference, right ?

@lunny
Copy link
Member Author

lunny commented Feb 10, 2017

@strk you are right!

@lunny
Copy link
Member Author

lunny commented Feb 10, 2017

@strk done.

@Bwko
Copy link
Member

Bwko commented Feb 10, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2017
@lunny lunny merged commit cf0f451 into go-gitea:master Feb 11, 2017
@lunny lunny deleted the lunny/track_delete_branch branch February 11, 2017 04:06
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull request branch delete message could be in the log
5 participants