Bug fixed for deleted label in issue comment #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tboerger
added
the
lgtm/need 1
thehowl
reviewed
Feb 11, 2017
| </div> | ||
| {{else if eq .Type 7}} | ||
| {{if .Label}} | ||
| <div class="event"> |
There was a problem hiding this comment.
Shouldn't the code block inside the new if be further indented?
There was a problem hiding this comment.
No. It's different logic. I would like let it two if
There was a problem hiding this comment.
Yes, I understand why you're using two ifs, I'm saying that it should be like this
{{else if eq .Type 7}}
{{if .Label}}
<div class="event">
...
instead of like this
{{else if eq .Type 7}}
{{if .Label}}
<div class="event">
...
|
Will you fix this for milestones as well #804? Or should that be a different PR/issue? |
|
@jeppech I will send another PRs to fix them. |
appleboy
approved these changes
Feb 11, 2017
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #894