Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependent packages: #462

Merged
merged 6 commits into from Sep 7, 2023
Merged

Update dependent packages: #462

merged 6 commits into from Sep 7, 2023

Conversation

iredmail
Copy link
Contributor

@iredmail iredmail commented Sep 2, 2023

  • github.com/google/uuid v1.3.1
  • golang.org/x/crypto v0.12.0

github.com/google/uuid v1.3.1
github.com/stretchr/testify v1.8.4
golang.org/x/crypto v0.12.0
Copy link
Member

@cpuschma cpuschma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. May you mirror the changes to the root directories go.mod and go.sum as well?

Additionally, I just checked and it seems, due to Go 1.21.0, that golang.org/x/crypto has been updated to v0.13.0. May you please run go get -u ./... again?

@iredmail
Copy link
Contributor Author

iredmail commented Sep 6, 2023

According to current v3/go.mod, it requires Go 1.14, do we set it to 1.21.0 or stick to 1.14?
testify package has new version too, but it requires newer Go release.

@cpuschma
Copy link
Member

cpuschma commented Sep 6, 2023

We stick with Go 1.14 unless it's necessary to drop support for it. In both cases this should be addressed in a separate PR

@iredmail
Copy link
Contributor Author

iredmail commented Sep 6, 2023

hi @cpuschma,

Bumped crypto to v0.13.0, please help review and hopefully merge it. :)

@cpuschma
Copy link
Member

cpuschma commented Sep 6, 2023

Thank you. Can you update the deps for the root directories go.mod as well? Then we can merge it

@iredmail
Copy link
Contributor Author

iredmail commented Sep 7, 2023

@cpuschma Done. :)

@cpuschma cpuschma merged commit 07d2e09 into go-ldap:master Sep 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants