temp

Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>

Author: fredbi

TODO.md

@@ -0,0 +1,4 @@
+* +90% coverage
+* benchmark + graph (for future reference)
+* CONTRIBUTORS.md (ci pipeline)
+* fuzz test

fuzz_test.go

@@ -0,0 +1,21 @@
+package jsonpointer
+
+import (
+	"testing"
+
+	"github.com/go-openapi/testify/v2/require"
+)
+
+func FuzzParse(f *testing.F) {
+	for _, generator := range allGenerators {
+		for _, testCase := range generator() {
+			f.Add(testCase.uriRaw)
+		}
+	}
+
+	f.Fuzz(func(t *testing.T, input string) {
+		require.NotPanics(t, func() {
+			_, _ = Parse(input)
+		})
+	})
+}

pointer.go

@@ -114,18 +114,18 @@ func (p *Pointer) Offset(document string) (int64, error) {
 
 // "Constructor", parses the given string JSON pointer
 func (p *Pointer) parse(jsonPointerString string) error {
-	var err error
-
-	if jsonPointerString != emptyPointer {
-		if !strings.HasPrefix(jsonPointerString, pointerSeparator) {
-			err = errors.Join(ErrInvalidStart, ErrPointer)
-		} else {
-			referenceTokens := strings.Split(jsonPointerString, pointerSeparator)
-			p.referenceTokens = append(p.referenceTokens, referenceTokens[1:]...)
-		}
+	if jsonPointerString == emptyPointer {
+		return nil
+	}
+
+	if !strings.HasPrefix(jsonPointerString, pointerSeparator) {
+		return errors.Join(ErrInvalidStart, ErrPointer)
 	}
 
-	return err
+	referenceTokens := strings.Split(jsonPointerString, pointerSeparator)
+	p.referenceTokens = append(p.referenceTokens, referenceTokens[1:]...)
+
+	return nil
 }
 
 func (p *Pointer) get(node any, nameProvider *jsonname.NameProvider) (any, reflect.Kind, error) {

pointer_test.go

@@ -367,7 +367,7 @@ func TestOtherThings(t *testing.T) {
 		require.Error(t, err)
 	})
 
-	t.Run("resolving pointer against an unsupport type (int) should error", func(t *testing.T) {
+	t.Run("resolving pointer against an unsupported type (int) should error", func(t *testing.T) {
 		p, err := New("/invalid")
 		require.NoError(t, err)
 		_, _, err = p.Get(1234)
@@ -861,3 +861,16 @@ func TestOffset(t *testing.T) {
 		})
 	}
 }
+
+func TestEdgeCases(t *testing.T) {
+	t.Parallel()
+
+	t.Run("set at pointer against an unsupported type (int) should error", func(t *testing.T) {
+		p, err := New("/invalid")
+		require.NoError(t, err)
+		_, err = p.Set(1, 1234)
+		require.Error(t, err)
+		require.ErrorIs(t, err, ErrUnsupportedValueType)
+	})
+
+}