Proposed interface for triangulation #23
Conversation
Add the description for an interface for triangulation.
gdey
assigned
gdey,
ARolek and
jasonsurratt and unassigned
gdey,
ARolek and
jasonsurratt
|
@olt would love to get your input on this as well. |
planar/triangulate/triangulate.go
Outdated
|
|
||
| type Interface interface { | ||
| // SetPoints sets the nodes to be used in the triangulation | ||
| SetPoints(pts []geom.Point, data []interface{}) |
There was a problem hiding this comment.
Should SetPoints overwrite all existing points? If not, then I would call it AddPoints.
There was a problem hiding this comment.
What about error handling? Could there be any conditions where the added points are invalid? When should the triangulation happen? I think either SetPoints or Triangles should be allowed to return an error (if not both).
There was a problem hiding this comment.
Data is arbitary data that maybe attached to the vertex.
There was a problem hiding this comment.
How can we access the data? Via geom.Triangle? Is the same data attached to all vertices that are build from pts?
There was a problem hiding this comment.
This is a good point. Maybe Triangles should return a [][3]interface{} for the data associated with each triangle? The more I think about this, the more I think we should drop the metadata, and allow the user to manage that outside of this interface.
planar/triangulate/triangulate.go
Outdated
| Triangles() []geom.Triangle | ||
| } | ||
|
|
||
| type Constrainer interface { |
There was a problem hiding this comment.
This should probably come with a bit more description. Maybe reference Constrained Delaunay triangulation?
There was a problem hiding this comment.
If AddContraints is always tied to a Triangulator, then I would call this interface ContrainedTriangulator and embed the Triangulator interface:
type ContrainedTriangulator interface {
Triangulator
AddConstraints(constraints ...geom.Line) error
}
planar/triangulate/triangulate.go
Outdated
|
|
||
| import "github.com/go-spatial/geom" | ||
|
|
||
| type Interface interface { |
planar/triangulate/triangulate.go
Outdated
|
|
||
| type Interface interface { | ||
| // SetPoints sets the nodes to be used in the triangulation | ||
| SetPoints(pts []geom.Point, data []interface{}) |
There was a problem hiding this comment.
What about error handling? Could there be any conditions where the added points are invalid? When should the triangulation happen? I think either SetPoints or Triangles should be allowed to return an error (if not both).
planar/triangulate/triangulate.go
Outdated
| Triangles() []geom.Triangle | ||
| } | ||
|
|
||
| type Constrainer interface { |
There was a problem hiding this comment.
If AddContraints is always tied to a Triangulator, then I would call this interface ContrainedTriangulator and embed the Triangulator interface:
type ContrainedTriangulator interface {
Triangulator
AddConstraints(constraints ...geom.Line) error
}
5f8df51 to
0cdd71d
Compare
Updated interfaces according to feedback.
gdey
force-pushed
the
triangulation_interface
branch
from
0cdd71d to
fcb58ca
Compare
|
closed via #88 |
5 participants
This pull request is here to discuss the Proposed triangulation interface.
Add the description for an interface for triangulation.