Skip to content

Port constrained #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2019
Merged

Port constrained #88

merged 2 commits into from
Nov 5, 2019

Conversation

gdey
Copy link
Member

@gdey gdey commented Nov 4, 2019

No description provided.

@gdey gdey requested a review from ear7h November 4, 2019 07:31
@coveralls
Copy link

coveralls commented Nov 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 416

  • 1080 of 2521 (42.84%) changed or added relevant lines in 34 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 57.511%
Changes Missing Coverage Covered Lines Changed/Added Lines %
planar/triangulate/delaunay/quadedge/errors.go 0 1 0.0%
planar/triangulate/delaunay/quadedge/test_helpers.go 13 14 92.86%
planar/clip/linestring.go 1 3 33.33%
encoding/wkt/errors.go 0 3 0.0%
planar/makevalid/hitmap/polygon_hitmap.go 1 4 25.0%
planar/makevalid/hitmap/ring.go 0 3 0.0%
planar/triangulate/delaunay/subdivision/triangle.go 0 3 0.0%
geom.go 0 4 0.0%
planar/makevalid/makevalid.go 5 9 55.56%
encoding/wkt/wkt_encode.go 2 9 22.22%
Files with Coverage Reduction New Missed Lines %
cmp/default_compare.go 1 74.47%
planar/makevalid/makevalid.go 1 53.63%
planar/makevalid/triangulate.go 1 54.55%
planar/makevalid/walker/walker.go 2 60.07%
Totals Coverage Status
Change from base Build 401: -0.03%
Covered Lines: 28066
Relevant Lines: 48801
💛 - Coveralls

@gdey gdey force-pushed the port_constrained branch from f37dc92 to b2fa99e Compare November 4, 2019 17:58
ear7h
ear7h requested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@ear7h ear7h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge! And it's awesome to see this pr into master. I didn't get too deep into the math, though, I know it's been visually verified in tegola. My comments are mostly polish. I also noticed a few things that maybe could be optimized but, I'll open a separate issue for that. Thank you Gautam!

ARolek
ARolek requested changes Nov 4, 2019
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions inline, mainly purging potentially dead code. Also I think that the test files should use the wkt extension rather than .points, or .lines. You can communicate the geom type in the file name (i.e. florida_lines.wkt).

@gdey gdey requested a review from ear7h November 4, 2019 19:53
@gdey gdey force-pushed the port_constrained branch 2 times, most recently from 4ddecd7 to bce5c1a Compare November 4, 2019 22:49
ear7h
ear7h approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@ear7h ear7h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ear7h
ear7h reviewed Nov 4, 2019
View reviewed changes
@gdey gdey force-pushed the port_constrained branch from bce5c1a to f22a814 Compare November 5, 2019 00:05
ear7h
ear7h approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@ear7h ear7h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2

@gdey gdey force-pushed the port_constrained branch from f22a814 to 1232cef Compare November 5, 2019 00:16
@gdey gdey merged commit fc18549 into master Nov 5, 2019
@ear7h ear7h mentioned this pull request Nov 5, 2019
Closed
@gdey gdey deleted the port_constrained branch November 5, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARolek ARolek ARolek approved these changes

@ear7h ear7h ear7h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gdey @coveralls @ARolek @ear7h