enable Cache-Control headers on S3 caches #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1286
💛 - Coveralls |
ear7h
requested changes
Jul 9, 2018
|
I've added the documentation |
ARolek
approved these changes
Jul 11, 2018
|
LGTM. |
sacontreras
pushed a commit
to sacontreras/tegola
that referenced
this pull request
Aug 18, 2018
* 'master' of sacontreras-GitHub:go-spatial/tegola: (125 commits) Update README.md updating readme and changelog for v0.7.0. go-spatial#490 (go-spatial#492) added TEGOLA_ prefix to SQL_DEBUG env var. closes go-spatial#489 (go-spatial#491) support for lambda during CI build fix for PGX numeric types sharing pointer reference (go-spatial#487) make min / max zoom flags consistant. closes go-spatial#480 (go-spatial#483) enable Go pprof profiler with TEGOLA_HTTP_PPROF_BIND environment (go-spatial#462) Cache seed improvements (go-spatial#454) minor documentation polish to postgis layer geometry_type provider/postgis: add geometry_type option to avoid table inspection (go-spatial#466) Update README.md to correct "Server" heading spelling (go-spatial#476) Update README.md (go-spatial#473) force remove on CGO builds split CGO and non CGO build flow updated xgo work flow for cross compile of CGO builds set CI_DIR var in build binary CI script modified deploy condition in travis Issue 420 (go-spatial#471) postgis: add support for !bbox! (Mapnik) and !BOX! (MapServer) tokens (go-spatial#461) enable Cache-Control headers on S3 caches (go-spatial#448) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the slightly messy commit history, but basically it is a round about way to sync my fork with upstream
In the end it is just a small change in s3.go, similar to the ACL functionality. I've tested it with Digital Ocean's spaces and I'm 99% sure it will work with S3 as well, since it is using the S3 API. solves #447