Skip to content

Conversation

olt
Copy link
Contributor

@olt olt commented Jul 19, 2018

addressed in #180

This feature is important for more complex queries (joins or spatial operations) were a LIMIT 1 still has to run against the whole table (because !BBOX! covers the whole planet).

@olt olt requested review from ARolek and gdey as code owners July 19, 2018 12:12
@coveralls
Copy link

coveralls commented Jul 19, 2018

Pull Request Test Coverage Report for Build 1294

  • 17 of 33 (51.52%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 43.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/postgis/postgis.go 17 33 51.52%
Totals Coverage Status
Change from base Build 1292: 0.02%
Covered Lines: 5048
Relevant Lines: 11618

💛 - Coveralls

@ARolek ARolek merged commit 4320470 into go-spatial:v0.7.0 Jul 30, 2018
@ARolek
Copy link
Member

ARolek commented Jul 30, 2018

@olt this looks great! Also, thanks for cleaning up the internal PostGIS test.

sacontreras pushed a commit to sacontreras/tegola that referenced this pull request Aug 18, 2018
* 'master' of sacontreras-GitHub:go-spatial/tegola: (125 commits)
  Update README.md
  updating readme and changelog for v0.7.0. go-spatial#490 (go-spatial#492)
  added TEGOLA_ prefix to SQL_DEBUG env var. closes go-spatial#489 (go-spatial#491)
  support for lambda during CI build
  fix for PGX numeric types sharing pointer reference (go-spatial#487)
  make min / max zoom flags consistant. closes go-spatial#480 (go-spatial#483)
  enable Go pprof profiler with TEGOLA_HTTP_PPROF_BIND environment (go-spatial#462)
  Cache seed improvements (go-spatial#454)
  minor documentation polish to postgis layer geometry_type
  provider/postgis: add geometry_type option to avoid table inspection (go-spatial#466)
  Update README.md to correct "Server" heading spelling (go-spatial#476)
  Update README.md (go-spatial#473)
  force remove on CGO builds
  split CGO and non CGO build flow
  updated xgo work flow for cross compile of CGO builds
  set CI_DIR var in build binary CI script
  modified deploy condition in travis
  Issue 420 (go-spatial#471)
  postgis: add support for !bbox! (Mapnik) and !BOX! (MapServer) tokens (go-spatial#461)
  enable Cache-Control headers on S3 caches (go-spatial#448)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants