Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cloudsql dialer #1007

Merged
merged 1 commit into from Oct 1, 2019
Merged

remove cloudsql dialer #1007

merged 1 commit into from Oct 1, 2019

Conversation

@julienschmidt
Copy link
Member

julienschmidt commented Sep 30, 2019

CloudSQL is only available up to Go 1.9 on Google AppEngine, which was phased out. Starting from 2019-10-01, no new apps can be deployed to GAE/Go 1.9 anymore. This dialer is thus obsolete.

Fixes #1002

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
@julienschmidt julienschmidt added this to the v1.5.0 milestone Sep 30, 2019
@julienschmidt julienschmidt requested a review from methane Sep 30, 2019
@methane
methane approved these changes Oct 1, 2019
@julienschmidt julienschmidt merged commit 59de189 into master Oct 1, 2019
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-0.07%) to 80.693%
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@julienschmidt julienschmidt deleted the cloudsql branch Oct 1, 2019
@jsha jsha mentioned this pull request Nov 14, 2019
@arp242 arp242 mentioned this pull request Feb 1, 2020
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.