New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict mode #676

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@julienschmidt
Copy link
Member

julienschmidt commented Sep 29, 2017

Description

We know for a while already that our strict mode can cause a lot of problems and is not safe to use. See #556 #602 #635

A proper server-side mode should be set instead of this driver-side hack.

This PR removes the strict mode completely.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
Remove strict mode
Fixes #556 #602 #635
Closes #609

@julienschmidt julienschmidt added the bug label Sep 29, 2017

@julienschmidt julienschmidt added this to the v1.4 milestone Sep 29, 2017

@julienschmidt julienschmidt requested review from methane and arnehormann Sep 29, 2017

@julienschmidt

This comment has been minimized.

Copy link
Member

julienschmidt commented Sep 29, 2017

@methane
Copy link
Contributor

methane left a comment

LGTM. Nice simplification.

dsn.go Outdated
if !isBool {
return errors.New("invalid bool value: " + value)
}
return errors.New("strict mode has been removed. See https://github.com/go-sql-driver/mysql/wiki/strict-mode")

This comment has been minimized.

@julienschmidt

julienschmidt Sep 30, 2017

Member

Should this panic?

@julienschmidt julienschmidt merged commit a8b7ed4 into master Oct 3, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 76.655%
Details

@julienschmidt julienschmidt deleted the strict branch Oct 3, 2017

scottjg added a commit to scottjg/mysql-driver that referenced this pull request Oct 3, 2017

Remove use of mysql.MySQLWarnings
It was removed from the upstream mysql package in
go-sql-driver/mysql#676

@LarsFronius LarsFronius referenced this pull request Oct 11, 2017

Merged

Vendors/locks deps #2

fho added a commit to simplesurance/migrate that referenced this pull request Oct 27, 2017

driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings
compilation failed with:
  driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings

MySQLWarnings was removed from the mysql driver
(go-sql-driver/mysql#676), remove it from
migrate

fho added a commit to simplesurance/migrate that referenced this pull request Oct 27, 2017

driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings
compilation failed with:
  driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings

MySQLWarnings was removed from the mysql driver
(go-sql-driver/mysql#676), remove it from
migrate

fho added a commit to simplesurance/migrate that referenced this pull request Oct 27, 2017

driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings
compilation failed with:
  driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings

MySQLWarnings was removed from the mysql driver
(go-sql-driver/mysql#676), remove it from
migrate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment