Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(compiler): add ruledata option to CompileLite #1076

Merged
merged 10 commits into from
Apr 5, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Mar 5, 2024

I'm visualizing a UI / CLI experience where users can use ruledata filters to watch their pipelines purge themselves in an interactive way:

vela validate pipeline --event push would return the pipeline that they can expect to run for a push event.

We could expand the pipeline tab in the UI to offer a similar process.

@ecrupper ecrupper requested a review from a team as a code owner March 5, 2024 18:25
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.28%. Comparing base (f591935) to head (4b50733).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   63.22%   63.28%   +0.06%     
==========================================
  Files         348      348              
  Lines       10585    10603      +18     
==========================================
+ Hits         6692     6710      +18     
  Misses       3407     3407              
  Partials      486      486              
Files Coverage Δ
compiler/native/compile.go 71.53% <87.87%> (+1.94%) ⬆️

@wass3rw3rk
Copy link
Member

test failures :(

Copy link
Contributor

@timhuynh94 timhuynh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants