Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/pipeline): correct type for path query param + add testing #1100

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Apr 5, 2024

Immediate follow up to #1076, as splitting a query value on a comma is very finicky given URL encoding and fortunately Gin and "github.com/google/go-querystring/query" (sdk-go) both handle multi key queries as a slice input.

@ecrupper ecrupper requested a review from a team as a code owner April 5, 2024 15:41
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.89%. Comparing base (0d08fc3) to head (4204f72).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
- Coverage   63.28%   61.89%   -1.40%     
==========================================
  Files         348      358      +10     
  Lines       10603    10885     +282     
==========================================
+ Hits         6710     6737      +27     
- Misses       3407     3662     +255     
  Partials      486      486              
Files Coverage Δ
api/pipeline/compile.go 55.10% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@ecrupper ecrupper merged commit fb31ea5 into main Apr 5, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/pipeline/path-query-type branch April 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants