Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PHP 8 #121

Closed
wants to merge 2 commits into from
Closed

Migrate to PHP 8 #121

wants to merge 2 commits into from

Conversation

jimbonator
Copy link

Makes the bare minimum of changes to work with PHP 8.

@jakublabno
Copy link

I think you should assure compatibility for both - 7.4 and >=8 versions. It may generate problems when migrating whole environment.

@jimbonator
Copy link
Author

I've updated the branch for compatibility with PHP 7.3 to 8.1.

I noticed the file .github/workflows/phpunit.yml. It appears to run the unit tests under PHP 7.3 and 7.4. Should I also update that file to run the tests under PHP 8.0 and 8.1?

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@jakublabno
Copy link

It's no longer compatible with 7.3 and 7.4.

@jimbonator
Copy link
Author

It should be compatible at least with PHP 7.4. (We're using it in production now with that version.) What errors are you seeing? Is there some automation here I can use to see them myself?

@jimbonator
Copy link
Author

(Also, your prior comment said version 7.4 and 8, so I was not targeting 7.3 when I made my latest changes.)

@gavinkalika
Copy link

is there an update on this?

@jakublabno
Copy link

is there an update on this?

I think there will not be any.
I've made my forks that support attributes on classes for 8.1

@lisachenko
Copy link
Member

Hello, guys! Do you have a working version of goaop/parser-reflection that supports 8.1? If yes - I can merge your PR here and give you maintainer rights on this repo. @jakublabno WDYT?

@lisachenko
Copy link
Member

I had previously problems with my health, thus decided to stop maintaining projects, but now I can return back to projects, at least in review/maintain mode. And really want to have main project goaop/framework running on PHP8.1

@gavinkalika
Copy link

is there an update on this?

I think there will not be any. I've made my forks that support attributes on classes for 8.1

May I see your forked branch?

@lisachenko
Copy link
Member

My proposal is to push existing master branch to the 3.x, take some existing work as main branch and make "master" alias for 4.x + bump minimum version to >=8.0.

@jakublabno
Copy link

Hello, guys! Do you have a working version of goaop/parser-reflection that supports 8.1? If yes - I can merge your PR here and give you maintainer rights on this repo. @jakublabno WDYT?

Yes, I have it working in my private repository fork, I've also made a pr to code generator library to have a possibility proxing classes with attributes.

https://github.com/laminas/laminas-code/pull/145/files

@jakublabno
Copy link

is there an update on this?

I think there will not be any. I've made my forks that support attributes on classes for 8.1

May I see your forked branch?

It's on my gitlab, I'll try to push it public later this week along with laminas code fork

@scottmdahl
Copy link

Any movement on this?

@lisachenko
Copy link
Member

Awaiting @jakublabno, maybe he will be able to open-source/publish his changes as a PR )

@jakublabno
Copy link

Yes, sorry, I remember about that, but recently I had no time to do anything despite my current projects.
I'll back to it once I have free time.

@lisachenko
Copy link
Member

Hopefully, will be covered by #122

@benjamw
Copy link

benjamw commented Sep 15, 2023

Any updates on this? This is blocking us from updating our project to PHP 8.2.

@votetake
Copy link

Any updates?

This is blocking me from updating my project tests to PHP 8.2

@uzmasterdev
Copy link

@lisachenko @jakublabno really need this working on php 8, guys, please help to push this.

@TomasVotruba
Copy link

Resolved in https://github.com/goaop/parser-reflection/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aclosed+author%3Asamsonasik

@lisachenko lisachenko closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

10 participants