-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to PHP 8 #121
Migrate to PHP 8 #121
Conversation
I think you should assure compatibility for both - 7.4 and >=8 versions. It may generate problems when migrating whole environment. |
I've updated the branch for compatibility with PHP 7.3 to 8.1. I noticed the file |
The inspection completed: No new issues |
It's no longer compatible with 7.3 and 7.4. |
It should be compatible at least with PHP 7.4. (We're using it in production now with that version.) What errors are you seeing? Is there some automation here I can use to see them myself? |
(Also, your prior comment said version 7.4 and 8, so I was not targeting 7.3 when I made my latest changes.) |
is there an update on this? |
I think there will not be any. |
Hello, guys! Do you have a working version of goaop/parser-reflection that supports 8.1? If yes - I can merge your PR here and give you maintainer rights on this repo. @jakublabno WDYT? |
I had previously problems with my health, thus decided to stop maintaining projects, but now I can return back to projects, at least in review/maintain mode. And really want to have main project |
May I see your forked branch? |
My proposal is to push existing master branch to the 3.x, take some existing work as main branch and make "master" alias for 4.x + bump minimum version to >=8.0. |
Yes, I have it working in my private repository fork, I've also made a pr to code generator library to have a possibility proxing classes with attributes. |
It's on my gitlab, I'll try to push it public later this week along with laminas code fork |
Any movement on this? |
Awaiting @jakublabno, maybe he will be able to open-source/publish his changes as a PR ) |
Yes, sorry, I remember about that, but recently I had no time to do anything despite my current projects. |
Hopefully, will be covered by #122 |
Any updates on this? This is blocking us from updating our project to PHP 8.2. |
Any updates? This is blocking me from updating my project tests to PHP 8.2 |
@lisachenko @jakublabno really need this working on php 8, guys, please help to push this. |
Makes the bare minimum of changes to work with PHP 8.