Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace path separators with os.path.join #3

Closed
ghost opened this issue Jul 16, 2016 · 0 comments · Fixed by #13
Closed

Replace path separators with os.path.join #3

ghost opened this issue Jul 16, 2016 · 0 comments · Fixed by #13
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Jul 16, 2016

Path separators are written as plain strings, such as this:

dstfile = basedir + "/" + os.path.basename(imgpath)

this is bad practice. They should be written as this:

dstfile = os.path.join(basedir, os.path.basename(imgpath))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replacing path concatenation with os.path.join set-killer/collada-exporter
1 participant
@Calinou