Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Main branch Godot from source for Windows(constant errors) #37799

Closed
CROmartin opened this issue Apr 11, 2020 · 7 comments · Fixed by #38242
Closed

Building Main branch Godot from source for Windows(constant errors) #37799

CROmartin opened this issue Apr 11, 2020 · 7 comments · Fixed by #38242

Comments

@CROmartin
Copy link

CROmartin commented Apr 11, 2020

Godot version:
Master branch
OS/device including version:
Win 10 home
Issue description:
Error occur image:
Image
Steps to reproduce:
Download Python 3.8.2 install it with all requirements, install VS with required c++ packages, install SCons 3.1.1(stable), install pywin32 for multi threading, clone master branch with Git Bash, try to build Godot with SCons and then it fails while building.
Minimal reproduction project:

@akien-mga
Copy link
Member

Did you install the Windows SDK?

@CROmartin
Copy link
Author

Did you install the Windows SDK?

image

@Anutrix
Copy link
Contributor

Anutrix commented Apr 12, 2020

Try a different compiler for now.

@Anutrix
Copy link
Contributor

Anutrix commented Apr 12, 2020

In a future version of MSVC, doesn't transitively include.

BinomialLLC/basis_universal@8cd0074 is most probably the reason.
But there hasn't been a new release version upstream with this patch so I am not sure if should get the latest commit or wait for a new release.

@akien-mga
Copy link
Member

But there hasn't been a new release version upstream with this patch so I am not sure if should get the latest commit or wait for a new release.

We're already tracking an upstream commit and not a stable release, so we can update to latest master.

@CROmartin
Copy link
Author

In a future version of MSVC, doesn't transitively include.

BinomialLLC/basis_universal@8cd0074 is most probably the reason.
But there hasn't been a new release version upstream with this patch so I am not sure if should get the latest commit or wait for a new release.

Adding library in basisu_enc.h will solve problem. So as I understand all older versions of Godot will not compatible with VS 2019(then it is better use older version like VS 2017?) with out adding this library, new version of Godot will adapt to a changes made by VS 2019?

Thanks on help @akien-mga && @Anutrix

@akien-mga
Copy link
Member

So as I understand all older versions of Godot will not compatible with VS 2019(then it is better use older version like VS 2017?) with out adding this library, new version of Godot will adapt to a changes made by VS 2019?

Basis universal is a new dependency for Godot 4.0, the 3.2 branch and earlier don't include it and won't have this build issue.

@akien-mga akien-mga added this to the 4.0 milestone Apr 12, 2020
@akien-mga akien-mga self-assigned this Apr 21, 2020
akien-mga added a commit to akien-mga/godot that referenced this issue Apr 27, 2020
akien-mga added a commit that referenced this issue May 25, 2020
akien-mga added a commit that referenced this issue May 25, 2020
akien-mga added a commit that referenced this issue May 25, 2020
akien-mga added a commit that referenced this issue May 28, 2020
halotroop2288 pushed a commit to Homebrodot/Godot that referenced this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment