Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on bell button does nothing #56550

Closed
Chaosus opened this issue Jan 6, 2022 · 4 comments · Fixed by #62009
Closed

Clicking on bell button does nothing #56550

Chaosus opened this issue Jan 6, 2022 · 4 comments · Fixed by #62009

Comments

@Chaosus
Copy link
Member

Chaosus commented Jan 6, 2022

Godot version

b238218

System information

Windows 10

Issue description

Clicking on
image
does nothing. I think if there is no effect that button should be either disabled or hidden. Plus it does not have a tooltip.

Steps to reproduce

^^

Minimal reproduction project

No response

@Chaosus Chaosus added this to the 4.0 milestone Jan 6, 2022
@Chaosus Chaosus added bug and removed enhancement labels Jan 6, 2022
@KoBeWi
Copy link
Member

KoBeWi commented Jan 6, 2022

It toggles the toaster notifications.
8ngR0Dx9bb

@Chaosus
Copy link
Member Author

Chaosus commented Jan 6, 2022

Ah, yeah, I have a "show internal errors in toast notification" in the disabled(auto) state (which is on by default), so pressing it does not have any effect almost always.

Maybe it's a good idea to hide this button if there are no toast notifications to remove the user's confusion?

@gerhean
Copy link
Contributor

gerhean commented Jan 8, 2022

Another thing I noticed when pressing this bell button is that it still displays errors which has already been resolved. This can also be confusing.

Demo:
image

After resolving the error, the error message is still there:
image

@akien-mga
Copy link
Member

The "show internal errors in toast notification" setting is enabled on target=debug builds, and disabled on target=release_debug (so e.g. official 4.0 alpha 1 builds have this disabled as they use target=release_debug).

That's intentional, as we're not convinced that those internal errors are actually useful to show in the toaster. However, some errors which might be relevant to show seem to be wrongly internal-only, and they should be changed. There might also be a double reporting of errors (e.g. the Parse Errors in the above screenshot are likely already reported somewhere else in the script editor, and having them again in the toaster is not useful).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants