Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Inspector resource selection menu re-opens instead of just hiding after clicking on the arrow button #57757

Open
Chaosus opened this issue Feb 7, 2022 · 2 comments

Comments

@Chaosus
Copy link
Member

Chaosus commented Feb 7, 2022

Godot version

3.x/4.0(be1adf4)

System information

Windows 10

Issue description

I expect the popup menu will hide (or show when its hidden) and not re-open again when clicking on the arrow button on any resource property in the inspector:

inspector_popup

Steps to reproduce

Click on any resource/object property in the inspector

Minimal reproduction project

No response

@akien-mga
Copy link
Member

Confirmed in 3.x. Just to clarify as I initially misunderstood the GIF, on first click the PopupMenu is shown properly and doesn't flicker. The problem is that then clicking the arrow again makes it hide and reshow right away, instead of just hiding.

@Chaosus Chaosus changed the title Inspector resource menu re-opens instead of just hide after clicking on scrolling button The Inspector resource selection menu re-opens instead of just hiding after clicking on the arrow button Feb 8, 2022
@IgorKordiukiewicz
Copy link
Contributor

The EditorResourcePicker::_update_menu() is called every time the arrow button is clicked. And this function calls edit_menu->popup();. I tried checking if edit_menu is visible and only if not - calling popup(). But I don't think its possible because it gets hidden before that (the hide() function gets called by some signal, so maybe it gets hidden automatically because of mouse click outside the edit_menu area?).
Also the OptionButton's arrow button (e.g. CanvasItem -> Texture -> Filter) instead of hiding if already visible on pressed, it opens again and then hides so it should probably get fixed too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants