-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change editor description
of a child scene causing multiple open in editor
buttons in the Scene tab
#96567
Comments
Can reproduce it in v4.3.stable too |
I've identified the code responsible for this, will take a look at fixing it |
Nice! Is it #82916? |
That's indeed the PR that introduced it, thank you for finding it! |
Someone else will probably beat me to it, but here is what I found: godot/editor/gui/scene_tree_editor.cpp Line 519 in 139f998
We are adding the "Open in Editor" button every time the scene tree node tooltip is updated (signal gets emitted from the UI for description, in this case). This is only for inherited scenes or if So there should be a way to check if |
Indeed, see the fix above :) |
Tested versions
Godot V4.4 dev1.official
Godot V4.4 dev[906a4e9]
System information
Godot v4.4.dev1 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated Radeon RX 590 Series (Advanced Micro Devices, Inc.; 31.0.21905.1001) - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 Threads)
Issue description
In editor's Scene tab, a node of instanced scene has a button "open in editor"
What's wrong: there will be multiple "open in editor" buttons after changing the "editor description" of an instanced scene.
What's expected: there should be only one "open in editor" button and it already exists
P.S. I found this when i'm poking a instanced
.glb
scene's editor description.Steps to reproduce
Godot_v4.4dev1_EditorSceneTreeBug.mp4
Minimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered: