-
-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind many more properties to scripts #15611
Bind many more properties to scripts #15611
Conversation
Notable potentially breaking changes: - PROPERTY_USAGE_NOEDITOR is now PROPERTY_USAGE_STORAGE | PROPERTY_USAGE_NETWORK, without PROPERTY_USAGE_INTERNAL - Some properties were renamed, and sometimes even shadowed by new ones - New getter methods (some virtual) were added
[ci skip]
7ea2b90
to
ad79c70
Compare
Let's test in production™ and see what breaks :) This is quite important for 3.0 to have a consistent API. |
@@ -29,9 +29,6 @@ | |||
<member name="Geometry" type="Geometry" setter="" getter=""> | |||
[Geometry] singleton | |||
</member> | |||
<member name="GodotSharp" type="GodotSharp" setter="" getter=""> | |||
[GodotSharp] singleton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how those happened, I just ran doctool a few times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the mono build outputs this GodotSharp singleton. For the other issue, not sure.
@@ -1,4 +1,4 @@ | |||
<?xml version="1.0" encoding="UTF-8" ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm.. (bis)
Added notes about godotengine/godot#15611 (comment)
Notable potentially breaking changes:
Some notes I did while doing this:
Added a setter for VehicleBody.linear_velocity, hopefully it works.All the while someone made it extend RigidBody.While reviewing, please pay attention to the usage of the properties. It should not be
PROPERTY_USAGE_NOEDITOR
orDEFAULT
for properties that are not supposed to be saved to disk.