Added new scaling modes to splash screen #20541
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to scale the boot splash image is the option "Application/Boot Splash/fullsize" in the project settings. This PR adds 4 new ways of scaling: keep_width, keep_height, cover and expand and keeps the previous one (calling it full_size).
The old fullsize option looked like this:
And I replaced it for a new option I called "scale":
Here I show some pictures to illustrate how each scaling mode works. In each case an icon with size 64x64 is used:
The last one scales in the same way as the previous "fullsize" boolean option.
I updated both
rasterizer_gles2.cpp
andrasterizer_gles3.cpp
. I also realised that the old "fullsize" option was not working when using GLES2.This is my first PR so any tips, suggestions, recommendations... about anything are very welcome, specially if it's code-related.