Add more project window placement options #21150
Conversation
Calinou
force-pushed
the
more-window-placement-options
branch
from
62d9ec9
to
203af09
Compare
editor/editor_run.cpp
Outdated
| screen = OS::get_singleton()->get_current_screen(); | ||
| } else if (screen == 1) { | ||
| // Leftwards monitor (wrap to the other end if needed) | ||
| screen = abs((OS::get_singleton()->get_current_screen() - 1) % OS::get_singleton()->get_screen_count()); |
There was a problem hiding this comment.
You should use Math::abs, abs is not portable.
There was a problem hiding this comment.
Also, are we sure that all OSes identify monitors from left to right?
There was a problem hiding this comment.
Also, are we sure that all OSes identify monitors from left to right?
I don't think it's guaranteed as it depends on how monitors are set up, so I should perhaps rename the options.
Calinou
force-pushed
the
more-window-placement-options
branch
from
203af09
to
0a2a65a
Compare
editor/editor_run.cpp
Outdated
| screen = OS::get_singleton()->get_current_screen(); | ||
| } else if (screen == 1) { | ||
| // Leftwards monitor (wrap to the other end if needed) | ||
| screen = Math::abs((OS::get_singleton()->get_current_screen() - 1) % OS::get_singleton()->get_screen_count()); |
There was a problem hiding this comment.
I'm not sure this will do what you expect when current screen is 0, modulo operator on negative operands is implementation defined.
It would be safer (and cleaner) to use Math::wrapi() for that (and the screen == 2 case too I guess for consistency), since that's its purpose.
It is now possible to use the previous or next monitor (relative to the editor) to display running projects. If either end is reached, it will wrap around to the last or first monitor (respectively). This closes godotengine#20283.
Calinou
force-pushed
the
more-window-placement-options
branch
from
0a2a65a
to
475a46c
Compare
|
I updated this pull request, please check it again 🙂 |
|
Looks good, thanks! |
It is now possible to use the monitor on the left or on the right of the editor to display running projects. If either the left or right end is reached, it will wrap around to the last or first monitor (respectively).
It looks like
TTR()calls are not functional when used in setting hints (I tested it by setting the editor language to French, which translates the string mentioned), so I removed it in the setting hint.This closes #20283.